Intake Checklist

Name of FS : FS_HCM_PA_IT 906 Letters_Form001

Development ID(s) : HE024
SAP Objects name(s) : ZHE024_IT906_LETTERS_DISP, ZHF024_906_LETTERS_PRINT, ZHF024_906_LE

Check performed by - Name Kaustubh Khare

Role / Activity Technical Consultant
Review Date 5-Feb-13
All Total Issues
Clear
1 General Information
1.1 General information Required Information for :
- Project handling is given
- The functional pilot for further contact is identified.
1.2 SAP module / Row SAP Module is specified.
Row is specified for SAP HR module
1.3 SAP system and Development Is specified
class
1.4 Detailed description Is specified and sufficiently clear.

1.5 Select-Options And Parameters If a selection screen is present,this is specified

1.6 Authorization requirements If need to be controled by the program, this is specified

1.7 Data volume/frequency of If performance testing is required, this information is specified

execution information
1.8 Assumptions specified Assumptions are specified
1.9 Test data Test data is sufficient to test all the possible scenarios

1.91 Versions of the functional and The versions of the functional and technical specs are
technical specs consistent (Change History is maintained)
2 Data Dictionary
2.1 Tables For each table to be created during for the development, this
section is filled
2.2 Others If any other dictionary object need to be created (like
Matchcode, lock objects, index, …). The technical detail for
this are specified.
3 Reporting
3.1 General Object Name, Attributes , SAP-Application, Auth Grp, Log DB
name etc are mentioned
3.2 Report Columns description Are specified
3.3 Report headings structure If required, are specified
3.4 Report footer structure If required, are specified
3.5 Report Layout Are specified
3.6 ABAP Processing Sufficient to start
3.7 Description of Output Is specified
4 Interface
4.1 General Object Name, Attributes , SAP-Application, Auth Grp, Log DB
name etc are mentioned
4.2 Input and Output file description If the file formats are not specified in the SAP Data diictionary,
they are specified.
4.3 Interface data processing Is specified
4.4 BDC session description If a BDC session is part of the process, this is specified
4.5 Interface trigerring For a trigger by job, transaction, special interface tool, this is
specified
5 Transaction
5.1 General Object Name, Attributes, SAP-Application, Auth Grp, Screen
are mentioned for each transaction code using the module
pool
5.2 Screen layout Is specified for each screen
5.3 Field Definition Is specified for each field
5.4 Menu implementation Is specified for each menu
6 Form
6.1 General information General information including the language of the layout set to
be created/modified is specified
6.2 Form SAPScript, SmartForm Name, Steering Program Name,
Output Type are mentioned
6.3 Steering Program Changes If there is change in the steering program, it is specified.
6.4 Layout of the form Form Layout is drawn correctly with:
Placement of fields,
Ffield width in case of strings / multiline texts.
Source in case of logo / picture is provided.

7 Other
7.1 Error condition handling For any process requiring error processing, it is be specified

7.2 Others Any specific other requirement of this ticket mentioned

(Ok/Nok) with comments.

8 Estimation & Planning

8.1 Complexity / Estimation Is the Object complexity Correctly identified, Is Estimation
correct?

8.2 Planning Can the delivery date be met?

Ready for Development
Required Actions
OK Yes
NOK No
NA
take Checklist
Func Consultant : V Krishnamohan

TTERS_PRINT, ZHF024_906_LETTERS_STYLE, ZHG024_IT906_LETTER_DISPLAY, ZHG024_IT906_LETTERS

Review 1 Review 2 Review 3 Review 4 Review 5

Self Review

0 0 0 0
Comments, if any
NOK Please describe steps of how the

letter will be printed, tcode & steps

OK

OK

NOK Please mention how to identify which

letter is to be printed? Where user will
decide which letter will be printed?
Can user Edit the letter before
printing? how will he edit? Will letter
be stored every time it is printed? all
details have to be maintained
NA

NOK Please mention who can generate

letters? or if its managed through
stadard role please mention the same
OK

NA
NOK Not mentioned how will it be tested in
first place
NA

Comments, if any
OK

NA

Comments, if any
NA

NA
NA
NA
NA
NA
NA
Comments, if any
NA

NA

NA
NA
NA

Comments, if any
NA

NA
NA
NA
Comments, if any
OK

OK

NA
NOK Although, only letter has to be printed,

please mention header footer details,

if signatories have to be printed etc.

Comments, if any
NOK Please revisit error handling section
its completely irrelevant
NOK Text, maintenance and picking logic
has to be explained in details.

Comments, if any
NOK This is marked as medium, but this is
very complex object as it needs 1
smartform, one enhancement, text
classes, function group to be created
NA
No
Yes
 Clarifications Sheet
Development ID :
SAP ObjectsSpecific
name(s)#:

Document Ref ID / Sec Id Desciption Priority Request Requestor Requested Requested Expected Explanation Explanation
Name Stage Date From date of By
explanation
Real date of Status Comments
explanation
 Code Review Checklist
Development ID :
SAP Objects name(s) :

Review 1 Review 2 Review 3 Review 4

Check performed by - Name
Role / Activity Self Peer
Review Review
Review Date
All Clear 0 0 0 0

Naming Conventions and Declarations

1 Are names of Internal tables, Variables, Constants,
etc. declared as per naming standards.

2 Are variables / constants declared LIKE dictionary

fields, wherever possible.
3 Is Keyword Constant declared for non-modifiable
values.
4 Do individual / group of variables / constants have
appropriate comments, explaning their usage.

General
1 Is program title block as per the agreed standards

2 Are Events coded in correct sequence as per

Cookbook
3 Are Object names declared as per specification &
consistent in source code.
4 Are text elements declared as per standards &
maintained in required languages
5 Is formatting of amount and quantity fields done by
using CURRENCY and UNIT options
6 Is refreshing / clearing of work areas done, Always
at the beginning of the code & wherever required.
e.g. before a READ / SELECT Statement or before
moving value to the work area

7 Is maximum nesting level limited to 3 for control

LOOP and SELECT statements
8 Have ABAP code optimisation guidelines been
followed
9 Is complete key specified in case of Select Single
SQL statement.
10 Is internal table sorted with correct keys, when
using Binary search.
11 Is Screen design & Function Key assignment done
as per the SAP Style guide
12 Between Opening & Closing of a UNIX file,
minimum possible processing is done.
13 For Changes, Has the history section on the TOP
of ABAP updated with proper reference Id.
14 For Changes, the reference Id is placed on any
changed Line or Block of code, during the change
of an existing ABAP

Forms & Modules

1 Actual parameters which are being changed in a
FORM are passed with CHANGING option & not
USING.
2 Are naming standards followed for Formal
parameters for FOMS's
3 Are Function modules and related logic included in
separate Forms, wherever necessary
4 Do Formal parameter include parameter type
declaration
5 Is SY-SUBRC checked after each call to a function
module.

Code Alignment, Spacing and Formatting

1 Are ‘=’ and ‘TO’ aligned
2 Are Internal Comments aligned
3 Each logical block has a comment explaining its
functionality.
4 Are logically different Coding Blocks separated by
blank lines
5 Multiple statements on the same line do not exists

6 Is the format for SQL statements correct

7 Are ‘ENDIF’, ‘ENDLOOP’, ‘ENDAT’ etc.
commented (if necessary) to indicate the IF, LOOP
etc. they belong to
8 Is "Pretty Print" Function used to allign code.

Computation
1 Special operators CO, CA, CS etc. used instead of
programming similar operations
2 CONCATENATE statement used instead of
programming string concatenation
3 Fields of type I used for typical integer variables
like indices
4 Numeric literals or Named constants used with a
Number TYPE instead of character strings, if
dealing with type-I or type-P fields.

Error Handling
1 ‘Divide By Zero’ errors checked, by checking value
of the divisor to be nonzero before each division

2 Size Errors checked, to ensure that the sizes of

variables used for storing totals and additions are
large enough to hold anticipated maximum values

3 Is SY-SUBRC checked after CALL, OPEN, READ,

and SQL statements

Extended Check and Clean Up

Have following been removed :
1 · Unused tables from TABLES statement
2 · Unused variables
3 · Unused text elements
4 · Code segments which do nothing
5 · Commented out parts of the code
6 Is extended program check executed and all
errors/warnings removed
7 Has Code Inspector check executed and all
errors/warnings removed

Technical Specification Doc

1 Flow Logic is explained in detail
2 Specific FMs / Methods used in code are explained

3 Message class / no. / type / text used in object

described
4 Header / Footer / author / object info maintained
5 Most updated version is available on livelink
ecklist

Review 5 Review 6

0 0

Comments, if any

Comments, if any
Comments, if any

Comments, if any

Comments, if any

Comments, if any
Comments, if any

Comments, if any
 Unit Test Plan Review Checklist
Development ID :
SAP Objects name(s) :

Review 1 Review 2 Review 3 Review 4

Check performed by - Name
Role / Activity Self Review Peer
Review
Review Date
All Clear 0 0 0 0

Technical Test - (All test cases, must exists in UTP)

1 All input validations tested & corresponding test
cases included in UTP
2 Authority checks, if any, have been performed &
corresponding test cases included in UTP
3 All the OK_CODE's are tested correctly &
corresponding test cases included in UTP
4 All Logical statements are tested (valid, Invalid &
boundry conditions) & corresponding test cases
included in UTP
5 All Calculations/Formulas tested & corresponding
test cases included in UTP
6 Output checked for confirmance with the
requirement.
7 Control report and Error/Abend report generated(if
specified) for interface programs.
8 Test plan includes test scenarios for testing
database Locks & Commits, if any.
9 All the FORM's / logical blocks tested individually &
also with the overall context of the program.

Summary test plan check

1 Each Test cases were executed & desired results
achieved
Checklist

Review 5 Review 6

0 0

Comments, if any

Comments, if any